lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Aug 2007 01:24:29 +0400 From: "Denis V. Lunev" <dlunev@...il.com> To: Stephen Hemminger <shemminger@...ux-foundation.org> CC: "Denis V. Lunev" <dlunev@...il.com>, containers@...ts.osdl.org, netdev@...r.kernel.org, davem@...emloft.net Subject: Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device no, and this is important. Loopback is initialized in fs_initcall which is called sufficiently before module_init. I have checked the code and do not see initialization order mistakes right now. But, from now on, maintainer should pay attention for this unfortunate consequence :( Regards, Den Stephen Hemminger wrote: > On Fri, 24 Aug 2007 19:55:47 +0400 > "Denis V. Lunev" <dlunev@...il.com> wrote: > >> dlezcano@...ibm.com wrote: >>> From: Daniel Lezcano <dlezcano@...ibm.com> >>> >>> Doing this makes loopback.c a better example of how to do a >>> simple network device, and it removes the special case >>> single static allocation of a struct net_device, hopefully >>> making maintenance easier. >>> >>> Applies against net-2.6.24 >>> >>> Tested on i386, x86_64 >>> Compiled on ia64, sparc >> I think that a small note, that initialization order is changed will be >> good to record. After this, loopback MUST be allocated before any other >> networking subsystem initialization. And this is an important change. >> >> Regards, >> Den > > Yes, this code would break when other drivers are directly linked > in. > _______________________________________________ > Containers mailing list > Containers@...ts.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/containers > > _______________________________________________ > Devel mailing list > Devel@...nvz.org > https://openvz.org/mailman/listinfo/devel > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists