lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 24 Aug 2007 22:15:47 +0100 From: Al Viro <viro@....linux.org.uk> To: Stephen Hemminger <shemminger@...ux-foundation.org> Cc: Francois Romieu <romieu@...zoreil.com>, netdev@...r.kernel.org Subject: Re: [PATCH] via-velocity: use standard VLAN interface (resend) On Fri, Aug 24, 2007 at 01:56:49PM -0700, Stephen Hemminger wrote: > static void velocity_init_cam_filter(struct velocity_info *vptr) > { > struct mac_regs __iomem * regs = vptr->mac_regs; > + unsigned short vid; > - mac_set_cam(regs, 0, (u8 *) & (vptr->options.vid), VELOCITY_VLAN_ID_CAM); > + mac_set_cam(regs, 0, (u8 *) &vid, > + VELOCITY_VLAN_ID_CAM); This mac_set_cam() dreck should be split in two properly typed functions. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists