netdev - Re: [PATCH 2.6.23 RESEND] cxgb3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46D492A7.8040301@chelsio.com>
Date:	Tue, 28 Aug 2007 14:24:55 -0700
From:	Divy Le Ray <divy@...lsio.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, swise@...ngridcomputing.com
Subject: Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

Roland Dreier wrote:
>  > I take that back.  Rejected -- it breaks infiniband build.
>
> To be more precise:
>
>     drivers/infiniband/hw/cxgb3/cxio_hal.c: In function 'cxio_rdev_open':
>     drivers/infiniband/hw/cxgb3/cxio_hal.c:919: error: implicit declaration of function 'T3CDEV'
>
> it seems the problem is that T3CDEV() has been deleted and been
> replaced with the dev2t3cdev() inline function.  However a simple
> replacement s/T3CDEV/dev2t3cdev/ in drivers/infiniband/hw/cxgb3
> doesn't work because the function has moved from t3cdev.h to
> adapter.h; and moving the function back to t3cdev.h doesn't work
> because it depends on more structure definitions now.
>
> And at that point I gave up...
>   

Sorry about the compilation issue and the delay to reply.
I'll post a follow up for the iw_cxgb3 driver later this evening.
I plan to move the inlined dev2t3cdev() from adapter.h to an exported 
dev2t3cdev()
in cxgb3_offload.c.

Divy
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html