netdev - Re: make bnx2.c use msleep()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070828213926.GA12728@infradead.org>
Date:	Tue, 28 Aug 2007 22:39:26 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	mchan@...adcom.com, hch@...radead.org, arjan@...radead.org,
	netdev@...r.kernel.org
Subject: Re: make bnx2.c use msleep()

On Tue, Aug 28, 2007 at 02:32:50PM -0700, David Miller wrote:
> From: "Michael Chan" <mchan@...adcom.com>
> Date: Tue, 28 Aug 2007 15:21:30 -0700
> 
> > This is a special case since we are resetting the chip.  A read right
> > after chip reset will hang the bus especially for A0 and A1 and that's
> > why we need the msleep().  TG3 also has the same problem with chip
> > reset.  The code that comes after the msleep() will read and poll for
> > the reset to complete.
> 
> That's right, I forgot about this issue.
> 
> Thanks for explaining Michael.

The explanation should probably be added to the driver in form of
a comment..
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html