netdev - RE: [PATCH] e100 module loads 1/2 times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36D9DB17C6DE9E40B059440DB8D95F5203392179@orsmsx418.amr.corp.intel.com>
Date:	Tue, 28 Aug 2007 14:43:23 -0700
From:	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
To:	"Willy Tarreau" <w@....eu>,
	"Kok, Auke-jan H" <auke-jan.h.kok@...el.com>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH] e100 module loads 1/2 times

Willy Tarreau wrote:
> --- e100-3.5.17/src/e100.c.orig	2007-08-13 08:53:18 +0200
> +++ e100-3.5.17/src/e100.c	2007-08-13 09:24:56 +0200
> @@ -2934,13 +2934,13 @@
>  		printk(KERN_INFO PFX "%s\n", DRV_COPYRIGHT);
>  	}
>  #ifdef E100_USE_REBOOT_NOTIFIER
> -	retval = pci_register_driver(&e100_driver);
> -	if (retval >= 0)
> +	retval = pci_module_init(&e100_driver);
> +	if (retval == 0)
>  		register_reboot_notifier(&e100_notifier_reboot);
> 
>  	return retval;
>  #else
> -	return pci_register_driver(&e100_driver);
> +	return pci_module_init(&e100_driver);
>  #endif
>  }
> 

excellent catch willy!  Auke will make sure this gets upstream.

Thanks for your investigative work!  So strange that we had never gotten
other reports of it.

Jesse
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html