netdev - Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070905074411.GA4815@ludhiana>
Date:	Wed, 5 Sep 2007 00:44:11 -0700
From:	Mandeep Singh Baines <mandeep.baines@...il.com>
To:	Daniele Venzano <venza@...wnhat.org>
Cc:	Mandeep Singh Baines <mandeep.baines@...il.com>, hadi@...erus.ca,
	davem@...emloft.net, rick.jones2@...com, msb@...gle.com,
	netdev@...r.kernel.org, grundler@...gle.com,
	robert.olsson@....uu.se, jeff@...zik.org, nhorman@...driver.com
Subject: Re: [PATCH] [sis900] convert to NAPI, WAS Re: pktgen terminating
	condition

Daniele Venzano (venza@...wnhat.org) wrote:
> The patch looks good and I think it can be pushed higher (-mm ?) for some wider 
> testing. I don't have the hardware available to do some tests myself, 
> unfortunately, but it would be similar to yours anyway.
> 
> I'd like to know how this works for people with less memory and slower CPU, but any 
> kind of test run will be appreciated.

Hi Daniele,

I tested the driver under different setting of CPU clock. Under a lower clock,
I get less interrupts (what I was hoping for) and slightly less performance.
Under higher clock, I get better performance and almost 1 interrupt per packet.

I also made a tiny change to the driver which resulted in slightly better
performance and less interrupts. I made a one-line change to finish_xmit,
which now wakes up the transmit queue if there are at least 16 available
slots in the tx ring. Previously, the driver would wake up the transmit queue
if there was just a single slot available. This should result in better
hysteresis.

Attached are my test results and a new patch.

Signed-off-by: Mandeep Singh Baines <mandeep.baines@...il.com>

--

View attachment "sis900_napi_v2.patch" of type "text/plain" (19802 bytes)

View attachment "sis900_testingv2.txt" of type "text/plain" (2026 bytes)