netdev - Re: [PATCH resend] Fix a lock problem in generic phy code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1IUf6h-0006qu-00@gondolin.me.apana.org.au>
Date:	Mon, 10 Sep 2007 16:58:59 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	hjk@...utronix.de (Hans-J??rgen Koch)
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	jeff@...zik.org, afleming@...escale.com
Subject: Re: [PATCH resend] Fix a lock problem in generic phy code

Hans-J??rgen Koch <hjk@...utronix.de> wrote:
>
> The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel 2.6.23-rc4 and -rc3-mm1.

Could you please audit all instances of physdev->lock and add
_bh where necessary?  I can see that at least phys_stop also
needs the _bh.

We should also consider whether it makes sense to move the
timer into a work queue.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html