lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Sep 2007 09:24:23 -0600 From: ebiederm@...ssion.com (Eric W. Biederman) To: Pavel Emelyanov <xemul@...nvz.org> Cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org, Linux Containers <containers@...ts.osdl.org> Subject: Re: [PATCH 12/16] net: Support multiple network namespaces with netlink Pavel Emelyanov <xemul@...nvz.org> writes: > > Rrrrrr. This is the 5th or even the 6th patch that changes tens of files > but (!) most of these changes are just propagating some core thing into > protocols, drivers, etc. E.g. you add an argument to some function and > then make all the rest use it, but the chunk adding the argument itself > is buried in these changes. > > Why not make a reviewers' lifes easier and make (with hands) the core > hunks go first and the "propagation" ones at the end? For RFC purpose > I would even break the git-bisect safeness and splitted these patches > into 2 parts: those with the core and those with the propagation. Agreed, this is an issue for easy review. My apologies. I guess it was a failure in my imagination on how to prepare these patches for review, in a way that was both reviewer and preparer friendly. There is at least one /proc idiom change that needs to be made so I will keep this in mind for the resend. Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists