lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070911022110.GC1544@gondor.apana.org.au> Date: Tue, 11 Sep 2007 10:21:10 +0800 From: Herbert Xu <herbert.xu@...hat.com> To: Hans-Jürgen Koch <hjk@...utronix.de> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, jeff@...zik.org, afleming@...escale.com Subject: Re: [PATCH resend] Fix a lock problem in generic phy code On Mon, Sep 10, 2007 at 08:45:50PM +0200, Hans-Jürgen Koch wrote: > > > Could you please audit all instances of physdev->lock and add > > _bh where necessary? I can see that at least phys_stop also > > needs the _bh. > > I think the patch does all that's necessary. At least, there're no error > messages in the logs anymore. I didn't check if there's an error on > unload, though. Sorry, but you can't rely on the non-existence of lockdep messages as a proof of correctness :) If we're going to fix the obvious bugs here, we should fix the subtle ones too as otherwise they'll be much harder to notice with this patch merged. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists