netdev - Re: [PATCH 03/11] IB/ipoib: Bound the net device to the ipoib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aday7f5kk1t.fsf@cisco.com>
Date:	Mon, 17 Sep 2007 15:23:58 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	netdev@...r.kernel.org, monis@...taire.com, monisonlists@...il.com,
	ogerlitz@...taire.com, jgarzik@...ox.com, davem@...emloft.net,
	general@...ts.openfabrics.org
Subject: Re: [PATCH 03/11] IB/ipoib: Bound the net device to the ipoib_neigh structue

Overall idea looks good... one comment:

 > +	if (n->dev->flags & IFF_MASTER) {
 > +		/* n->dev is not an IPoIB device and we have
 > +			to take priv from elsewhere */
 > +		neigh = *to_ipoib_neigh(n);
 > +		if (neigh) {
 > +			priv = netdev_priv(neigh->dev);
 > +			ipoib_dbg(priv, "neigh_destructor for bonding device: %s\n",
 > +				  n->dev->name);
 > +		} else
 > +			return;
 > +	}

seems like it would be cleaner not to worry about bonding here and
just use neigh->dev all the time rather than having two ways to look
up the device.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html