lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 17 Sep 2007 15:25:55 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	netdev@...r.kernel.org, monis@...taire.com, monisonlists@...il.com,
	ogerlitz@...taire.com, jgarzik@...ox.com, davem@...emloft.net,
	general@...ts.openfabrics.org
Subject: Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

Actually, thinking about this some more... would it be cleaner to more
the knowledge about bonding out of the ipoib driver?  in other words,
export something similar to

 > +static int ipoib_slave_detach(struct net_device *dev)
 > +{
 > +	int ret = 0;
 > +	if (dev->flags & IFF_SLAVE) {
 > +		dev->priv_flags |= IFF_SLAVE_DETACH;
 > +		rtnl_lock();
 > +		ret = call_netdevice_notifiers(NETDEV_CHANGE, dev);
 > +		rtnl_unlock();
 > +	}
 > +	return ret;
 > +}

for drivers to use, rather than putting use of IFF_SLAVE and
IFF_SLAVE_DETACH outside of the bonding driver.

Also it seems this function could return void, since both call sites
ignore the return value and I don't see anything sensible that IPoIB
could do with the notifier chain return value anyway.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists