netdev - Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18593.1190071438@death>
Date:	Mon, 17 Sep 2007 16:23:58 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Roland Dreier <rdreier@...co.com>
cc:	netdev@...r.kernel.org, monis@...taire.com, monisonlists@...il.com,
	ogerlitz@...taire.com, jgarzik@...ox.com, davem@...emloft.net,
	general@...ts.openfabrics.org
Subject: Re: [PATCH 02/11] IB/ipoib: Notify the world before doing unregister 

Roland Dreier <rdreier@...co.com> wrote:

>Actually, thinking about this some more... would it be cleaner to more
>the knowledge about bonding out of the ipoib driver?  in other words,
>export something similar to
>
> > +static int ipoib_slave_detach(struct net_device *dev)
> > +{
> > +	int ret = 0;
> > +	if (dev->flags & IFF_SLAVE) {
> > +		dev->priv_flags |= IFF_SLAVE_DETACH;
> > +		rtnl_lock();
> > +		ret = call_netdevice_notifiers(NETDEV_CHANGE, dev);
> > +		rtnl_unlock();
> > +	}
> > +	return ret;
> > +}
>
>for drivers to use, rather than putting use of IFF_SLAVE and
>IFF_SLAVE_DETACH outside of the bonding driver.

	Conceptually, I see your point and I'm ok with doing it either
way.  My only question is, would this change would make the ipoib module
dependent upon having the bonding module loaded (to resolve all of the
symbols)?

	-J

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html