netdev - Re: [PATCH] Rename struct net to struct netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46EE9FDD.3090807@bull.net>
Date:	Mon, 17 Sep 2007 17:40:13 +0200
From:	Benjamin Thery <benjamin.thery@...l.net>
To:	Daniel Lezcano <dlezcano@...ibm.com>
Cc:	Pavel Emelyanov <xemul@...nvz.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] Rename struct net to struct netns

Daniel Lezcano wrote:
> Pavel Emelyanov wrote:
>> The name struct net is too generic. There already were
>> some people who wanted to have some better name (for
>> easier grep for example). I propose the struct netns one.
>>
>> The patch is (already) huge (sorry), but it's nothing but
>>   sed -e s/struct net\>/struct netns/g
>>
>> If this name is bad as well, let's select a new one
>> before the struct net floods the kernel.
> 
> [ SNIP ]
> 
>> --- a/include/linux/nsproxy.h
>> +++ b/include/linux/nsproxy.h
>> @@ -29,7 +29,7 @@ struct nsproxy {
>>      struct mnt_namespace *mnt_ns;
>>      struct pid_namespace *pid_ns;
>>      struct user_namespace *user_ns;
>> -    struct net          *net_ns;
>> +    struct netns          *net_ns;
> 
> IMHO, if we want to be consistent with all the rest of the namespaces,
> that should be net_namespace.

Sure it's a good argument. 
But I find that 'net', although it is an uber generic name, 
represents its contents appropriately: its function is to store
all data for a network stack, so it is what represent a network
in the kernel.

Anyway, if we want to change it, I think net_namespace is better
than netns because of the consistency argument given by Daniel.
(But it's longer :( )

Just my 2 cents.

Benjamin


> 
> [ SNIP ]


> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


-- 
B e n j a m i n   T h e r y  - BULL/DT/Open Software R&D

   http://www.bull.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html