netdev - Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070919174103.GB22795@infradead.org>
Date:	Wed, 19 Sep 2007 18:41:03 +0100
From:	'Christoph Hellwig' <hch@...radead.org>
To:	Alexander Indenbaum <baum@...utinetworks.net>
Cc:	'Christoph Hellwig' <hch@...radead.org>, jeff@...zik.org,
	davem@...emloft.org, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, 'Nadav Shemer' <nadav@...utinetworks.net>,
	'Andy Gospodarek' <andy@...yhouse.net>
Subject: Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

On Wed, Sep 19, 2007 at 07:37:18PM +0200, Alexander Indenbaum wrote:
> In my understanding unregister_netdev(), in case netdev is still IFF_UP and
> holds irq, will call dev_close() which will call netdev->stop(), bdx_close()
> in our case. bdx_close() releases all netdev resources among others calls
> free_irq().
> 
> That's why I'm pretty sure that we do not hold any reference to netdev after
> unregister_netdev() finishes and we can free_netdev() without any worry :)
> 
> What do you think, does it still look fishy?

Ok, so you do irq acquire/release in open/close so that bit is fine.
The code might actually work as is, sorry for the noise.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html