netdev - RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070919173724.C810375CC7@mail.tehutinetworks.co.il>
Date:	Wed, 19 Sep 2007 19:37:18 +0200
From:	"Alexander Indenbaum" <baum@...utinetworks.net>
To:	"'Christoph Hellwig'" <hch@...radead.org>
Cc:	<jeff@...zik.org>, <davem@...emloft.org>,
	<akpm@...ux-foundation.org>, <netdev@...r.kernel.org>,
	"'Nadav Shemer'" <nadav@...utinetworks.net>,
	"'Andy Gospodarek'" <andy@...yhouse.net>
Subject: RE: [PATCH] tehuti: driver for Tehuti 10GbE network adapters

> -----Original Message-----
> From: 'Christoph Hellwig' [mailto:hch@...radead.org]
> Sent: Wednesday, September 19, 2007 5:53 PM
>
> > Putting dual-port issue aside, could you elaborate what is the problem
> in
> > your opinion in bdx_remove() implementation? What is wrong with calling
> > free_netdev() right after unregister_netdev()? Could you provide
> pointers
> > for docs and examples to correct PCI network device remove interface
> > implementation?
> 
> free_netdev can only be called if you're sure you don't reference your
> netdevice anymore.  Most notably that means you need to call free_irq
> first.

In my understanding unregister_netdev(), in case netdev is still IFF_UP and
holds irq, will call dev_close() which will call netdev->stop(), bdx_close()
in our case. bdx_close() releases all netdev resources among others calls
free_irq().

That's why I'm pretty sure that we do not hold any reference to netdev after
unregister_netdev() finishes and we can free_netdev() without any worry :)

What do you think, does it still look fishy?

Alexander Indenbaum


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html