netdev - RE: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Sep 2007 12:12:49 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	<hadi@...erus.ca>, "David Miller" <davem@...emloft.net>
Cc:	<krkumar2@...ibm.com>, <johnpol@....mipt.ru>,
	<herbert@...dor.apana.org.au>, <kaber@...sh.net>,
	<shemminger@...ux-foundation.org>, <jagana@...ibm.com>,
	<Robert.Olsson@...a.slu.se>, <rick.jones2@...com>,
	<xma@...ibm.com>, <gaagaan@...il.com>, <netdev@...r.kernel.org>,
	<rdreier@...co.com>, <mcarlson@...adcom.com>, <jeff@...zik.org>,
	<mchan@...adcom.com>, <general@...ts.openfabrics.org>,
	<kumarkr@...ux.ibm.com>, <tgraf@...g.ch>,
	<randy.dunlap@...cle.com>, <sri@...ibm.com>
Subject: RE: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock

> I have submitted this before; but here it is again.
> Against net-2.6.24 from yesterday for this and all following patches. 
> 
> 
> cheers,
> jamal

Hi Jamal,
	I've been (slowly) working on resurrecting the original design
of my multiqueue patches to address this exact issue of the queue_lock
being a hot item.  I added a queue_lock to each queue in the subqueue
struct, and in the enqueue and dequeue, just lock that queue instead of
the global device queue_lock.  The only two issues to overcome are the
QDISC_RUNNING state flag, since that also serializes entry into the
qdisc_restart() function, and the qdisc statistics maintenance, which
needs to be serialized.  Do you think this work along with your patch
will benefit from one another?  I apologize for not having working
patches right now, but I am working on them slowly as I have some blips
of spare time.

Thanks,
-PJ Waskiewicz
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html