lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 24 Sep 2007 15:57:33 -0700 From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> To: <hadi@...erus.ca> Cc: "David Miller" <davem@...emloft.net>, <krkumar2@...ibm.com>, <johnpol@....mipt.ru>, <herbert@...dor.apana.org.au>, <kaber@...sh.net>, <shemminger@...ux-foundation.org>, <jagana@...ibm.com>, <Robert.Olsson@...a.slu.se>, <rick.jones2@...com>, <xma@...ibm.com>, <gaagaan@...il.com>, <netdev@...r.kernel.org>, <rdreier@...co.com>, <mcarlson@...adcom.com>, <jeff@...zik.org>, <mchan@...adcom.com>, <general@...ts.openfabrics.org>, <kumarkr@...ux.ibm.com>, <tgraf@...g.ch>, <randy.dunlap@...cle.com>, <sri@...ibm.com> Subject: RE: [PATCH 1/4] [NET_SCHED] explict hold dev tx lock > The one thing that seems obvious is to use > dev->hard_prep_xmit() in the patches i posted to select the > xmit ring. You should be able to do figure out the txmit ring > without holding any lock. I've looked at that as a candidate to use. The lock for enqueue would be needed when actually placing the skb into the appropriate software queue for the qdisc, so it'd be quick. > I lost track of how/where things went since the last > discussion; so i need to wrap my mind around it to make > sensisble suggestions - I know the core patches are in the > kernel but havent paid attention to details and if you look > at my second patch youd see a comment in > dev_batch_xmit() which says i need to scrutinize multiqueue more. No worries. I'll try to get things together on my end and provide some patches to add a per-queue lock. In the meantime, I'll take a much closer look at the batching code, since I've stopped looking at the patches in-depth about a month ago. :-( Thanks, -PJ Waskiewicz - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists