netdev - Re: [PATCH] make netlink processing routines semi-synchronious (inspired by rtnl)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4700F1B4.4090603@trash.net>
Date:	Mon, 01 Oct 2007 15:10:12 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	"Denis V. Lunev" <den@...nvz.org>
CC:	davem@...emloft.net, johannes@...solutions.net, tgraf@...g.ch,
	pablo@...filter.org, netdev@...r.kernel.org
Subject: Re: [PATCH] make netlink processing routines semi-synchronious	(inspired
 by rtnl)

Denis V. Lunev wrote:
> The code in netfilter/nfnetlink.c and in ./net/netlink/genetlink.c looks
> like outdated copy/paste from rtnetlink.c. Push them into sync with the
> original.
> 

>  int nfnetlink_subsys_register(const struct nfnetlink_subsystem *n)
> @@ -149,7 +137,7 @@ static int nfnetlink_rcv_msg(struct sk_b
>  #ifdef CONFIG_KMOD
>  		/* don't call nfnl_unlock, since it would reenter
>  		 * with further packet processing */
> -		__nfnl_unlock();
> +		nfnl_unlock();


That comment should be updated/deleted. Rest looks good to me.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html