netdev - Re: [PATCH 01/10] Preparatory refactoring part 1.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4700F54A.6070408@trash.net>
Date:	Mon, 01 Oct 2007 15:25:30 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Corey Hickey <bugfood-ml@...ooh.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 01/10] Preparatory refactoring part 1.

Corey Hickey wrote:
> Make a new function sfq_q_enqueue() that operates directly on the
> queue data. This will be useful for implementing sfq_change() in
> a later patch. A pleasant side-effect is reducing most of the
> duplicate code in sfq_enqueue() and sfq_requeue().
> 
> Similarly, make a new function sfq_q_dequeue().
> 
> Signed-off-by: Corey Hickey <bugfood-ml@...ooh.org>
> ---
>  net/sched/sch_sfq.c |   72 +++++++++++++++++++++++++++------------------------
>  1 files changed, 38 insertions(+), 34 deletions(-)
> 
> diff --git a/net/sched/sch_sfq.c b/net/sched/sch_sfq.c
> index 3a23e30..57485ef 100644
> --- a/net/sched/sch_sfq.c
> +++ b/net/sched/sch_sfq.c
> 

The sfq_q_enqueue part looks fine.

>  
> -	sch->qstats.drops++;

A line in the changelog explaining that this was increased twice
would have been nice.

>  	sfq_drop(sch);
>  	return NET_XMIT_CN;
>  }
>  
> -
> -
> -
> -static struct sk_buff *
> -sfq_dequeue(struct Qdisc* sch)
> +static struct
> +sk_buff *sfq_q_dequeue(struct sfq_sched_data *q)

What is this function needed for?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html