lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 02 Oct 2007 16:33:53 -0700 From: "Michael Chan" <mchan@...adcom.com> To: hadi@...erus.ca cc: "Matt Carlson" <mcarlson@...adcom.com>, "netdev" <netdev@...r.kernel.org> Subject: Re: [PATCH][TG3]Some cleanups On Tue, 2007-10-02 at 08:37 -0400, jamal wrote: > The simplest solution seems to me to modify the definition of > TG3_SKB_CB > as i did for e1000 from: > (struct tg3_tx_cbdata *)&((__skb)->cb[0]) > to: > (struct tg3_tx_cbdata *)&((__skb)->cb[8]) > > that way the vlan tags are always present and no need to recreate > them. > What do you think? Seems ok to me. I think we should make it more clear that we're skipping over the VLAN tag: (struct tg3_tx_cbdata *)&((__skb)->cb[sizeof(struct vlan_skb_tx_cookie)]) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists