netdev - Re: [PATCH][TG3]Some cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1191328627.4353.15.camel@localhost>
Date:	Tue, 02 Oct 2007 08:37:07 -0400
From:	jamal <hadi@...erus.ca>
To:	Michael Chan <mchan@...adcom.com>
Cc:	Matt Carlson <mcarlson@...adcom.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH][TG3]Some cleanups

On Mon, 2007-01-10 at 17:21 -0700, Michael Chan wrote:

> Jamal, in tg3_enqueue_buggy(), we may have to call tg3_tso_bug() which
> will recursively call tg3_start_xmit_dma_bug() after segmenting the TSO
> packet into normal packets.  We need to restore the VLAN tag so that the
> GSO code will create the chain of segmented SKBs with the proper VLAN
> tag.

Excellent eye Michael.
The simplest solution seems to me to modify the definition of TG3_SKB_CB
as i did for e1000 from:
(struct tg3_tx_cbdata *)&((__skb)->cb[0])
to:
(struct tg3_tx_cbdata *)&((__skb)->cb[8])

that way the vlan tags are always present and no need to recreate them.
What do you think?

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html