netdev - Re: [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 02 Oct 2007 12:55:29 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Dale Farnsworth <dale@...nsworth.org>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] mv643xx_eth: Do not modify struct netdev tx_queue_len

Dale Farnsworth wrote:
> From: Dale Farnsworth <dale@...nsworth.org>
> 
> This driver erroneously zeros dev->tx_queue_len, since
> mp->tx_ring_size has not yet been initialized.  Actually,
> the driver shouldn't modify tx_queue_len at all and should
> leave the value set by alloc_etherdev(), currently 1000.
> 
> Signed-off-by: Dale Farnsworth <dale@...nsworth.org>
> ---
> Jeff, this bug was just reported today, or I would have batched
> it with the one I sent you last week.  It's an obvious bugfix,
> so I'm not going to hold it in my queue.
> 
>  drivers/net/mv643xx_eth.c |    1 -
>  1 file changed, 1 deletion(-)

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html