netdev - Re: [PATCH] drivers/net/r8169.c - trivial - add KERN_DEBUG to dprintk and PFX before KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47027895.3050208@garzik.org>
Date:	Tue, 02 Oct 2007 12:57:57 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Joe Perches <joe@...ches.com>
CC:	Francois Romieu <romieu@...zoreil.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/r8169.c - trivial - add KERN_DEBUG to dprintk
 and PFX before KERN_ uses

Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@...ches.com>
> 
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index c921ec3..40019aa 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -44,7 +44,8 @@
>  		printk( "Assertion failed! %s,%s,%s,line=%d\n",	\
>  		#expr,__FILE__,__FUNCTION__,__LINE__);		\
>  	}
> -#define dprintk(fmt, args...)	do { printk(PFX fmt, ## args); } while (0)
> +#define dprintk(fmt, args...) \
> +	do { printk(KERN_DEBUG PFX fmt, ## args); } while (0)
>  #else
>  #define assert(expr) do {} while (0)
>  #define dprintk(fmt, args...)	do {} while (0)
> @@ -1924,7 +1925,7 @@ static void rtl_hw_start_8169(struct net_device *dev)
>  
>  	if ((tp->mac_version == RTL_GIGA_MAC_VER_02) ||
>  	    (tp->mac_version == RTL_GIGA_MAC_VER_03)) {
> -		dprintk(KERN_INFO PFX "Set MAC Reg C+CR Offset 0xE0. "
> +		dprintk("Set MAC Reg C+CR Offset 0xE0. "
>  			"Bit-3 and bit-14 MUST be 1\n");
>  		tp->cp_cmd |= (1 << 14);
>  	}

NAK these, the author clearly prefers his debugging output at KERN_INFO 
level


> @@ -2289,7 +2290,7 @@ static void rtl8169_reinit_task(struct work_struct *work)
>  	ret = rtl8169_open(dev);
>  	if (unlikely(ret < 0)) {
>  		if (net_ratelimit() && netif_msg_drv(tp)) {
> -			printk(PFX KERN_ERR "%s: reinit failure (status = %d)."
> +			printk(KERN_ERR PFX "%s: reinit failure (status = %d)."
>  			       " Rescheduling.\n", dev->name, ret);
>  		}
>  		rtl8169_schedule_work(dev, rtl8169_reinit_task);
> @@ -2321,7 +2322,7 @@ static void rtl8169_reset_task(struct work_struct *work)
>  		netif_wake_queue(dev);
>  	} else {
>  		if (net_ratelimit() && netif_msg_intr(tp)) {
> -			printk(PFX KERN_EMERG "%s: Rx buffers shortage\n",
> +			printk(KERN_EMERG PFX "%s: Rx buffers shortage\n",
>  			       dev->name);
>  		}

these are fixes, and should be in a separate patch


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html