netdev - Re: [patch] dm9601: Fix receive MTU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47027969.8060209@garzik.org>
Date:	Tue, 02 Oct 2007 13:01:29 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Peter Korsgaard <jacmet@...site.dk>
CC:	netdev@...r.kernel.org
Subject: Re: [patch] dm9601: Fix receive MTU

Peter Korsgaard wrote:
> Please apply to 2.6.23.
> ---
> dm9601 didn't take the ethernet header into account when calculating
> RX MTU, causing packets bigger than 1486 to fail.
> 
> Signed-off-by: Peter Korsgaard <jacmet@...site.dk>
> ---
>  drivers/net/usb/dm9601.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> ===================================================================
> --- linux-2.6.23-rc8.orig/drivers/net/usb/dm9601.c
> +++ linux-2.6.23-rc8/drivers/net/usb/dm9601.c
> @@ -405,7 +405,7 @@
>  	dev->net->ethtool_ops = &dm9601_ethtool_ops;
>  	dev->net->hard_header_len += DM_TX_OVERHEAD;
>  	dev->hard_mtu = dev->net->mtu + dev->net->hard_header_len;
> -	dev->rx_urb_size = dev->net->mtu + DM_RX_OVERHEAD;
> +	dev->rx_urb_size = dev->net->mtu + ETH_HLEN + DM_RX_OVERHEAD;

applied.  in the future, please note (and avoid) a patch formatting 
error.  As noted in #14 of Documentation/SubmittingPatches, any comments 
on the patch like "Please apply to 2.6.23" should go AFTER the patch 
description and "---" separator.

Without hand editing, the normal tools everybody uses for importing 
patches would delete your "dm9601 didn't take the ethernet header..." 
description, leaving only the "Please apply to 2.6.23." part and nothing 
else.

I did the hand-editing, but please try to follow the standard patch 
format in the future.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html