netdev - Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1191523488.7367.16.camel@johannes.berg>
Date:	Thu, 04 Oct 2007 20:44:48 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	Daniel Drake <dsd@...too.org>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH] ieee80211_if_set_type: make check for master dev more
	explicit

On Thu, 2007-10-04 at 14:09 -0400, John W. Linville wrote:

> --- a/net/mac80211/ieee80211_iface.c
> +++ b/net/mac80211/ieee80211_iface.c
> @@ -106,7 +106,7 @@ void ieee80211_if_set_type(struct net_device *dev, int type)
>  	 * which already has a hard_start_xmit routine assigned
>  	 * which must not be changed.
>  	 */
> -	if (!dev->hard_start_xmit)
> +	if (dev->type != ARPHRD_IEEE80211)
>  		dev->hard_start_xmit = ieee80211_subif_start_xmit;

That should work as well although I think you should update the comment
above :)

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)