lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 4 Oct 2007 15:13:01 -0400 From: "John W. Linville" <linville@...driver.com> To: Johannes Berg <johannes@...solutions.net> Cc: Daniel Drake <dsd@...too.org>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org Subject: Re: [PATCH] ieee80211_if_set_type: make check for master dev more explicit On Thu, Oct 04, 2007 at 08:44:48PM +0200, Johannes Berg wrote: > On Thu, 2007-10-04 at 14:09 -0400, John W. Linville wrote: > > > --- a/net/mac80211/ieee80211_iface.c > > +++ b/net/mac80211/ieee80211_iface.c > > @@ -106,7 +106,7 @@ void ieee80211_if_set_type(struct net_device *dev, int type) > > * which already has a hard_start_xmit routine assigned > > * which must not be changed. > > */ > > - if (!dev->hard_start_xmit) > > + if (dev->type != ARPHRD_IEEE80211) > > dev->hard_start_xmit = ieee80211_subif_start_xmit; > > That should work as well although I think you should update the comment > above :) The comment still seem applicable. How would you word it? -- John W. Linville linville@...driver.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists