netdev - Re: [PATCH]: Third (final?) release of Sun Neptune driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 05 Oct 2007 12:55:04 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Ingo Oeser <netdev@...eo.de>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Ariel.Hendel@....com, greg.onufer@....com,
	Ashley.Saulsbury@....com, Matheos.Worku@....com
Subject: Re: [PATCH]: Third (final?) release of Sun Neptune driver

Ingo Oeser wrote:
> Hi David,
> 
> some minor nits.
> 
> Could this driver be split into more files. 8k lines per file
> is quite a lot. Although GCC might optimize it best this way :-)

gcc does optimize it better this way, but overall, it's maintainer's 
preference.  It's far easier for many to have everything in a single 
file, when editing.


> David Miller schrieb:
>> +#define nr64(reg)		readq(np->regs + (reg))
>> +#define nw64(reg, val)		writeq((val), np->regs + (reg))
>> +
>> +#define nr64_mac(reg)		readq(np->mac_regs + (reg))
>> +#define nw64_mac(reg, val)	writeq((val), np->mac_regs + (reg))
>> +
>> +#define nr64_ipp(reg)		readq(np->regs + np->ipp_off + (reg))
>> +#define nw64_ipp(reg, val)	writeq((val), np->regs + np->ipp_off + (reg))
>> +
>> +#define nr64_pcs(reg)		readq(np->regs + np->pcs_off + (reg))
>> +#define nw64_pcs(reg, val)	writeq((val), np->regs + np->pcs_off + (reg))
>> +
>> +#define nr64_xpcs(reg)		readq(np->regs + np->xpcs_off + (reg))
>> +#define nw64_xpcs(reg, val)	writeq((val), np->regs + np->xpcs_off + (reg))
> 
> Can these be static inline and get the "struct niu *np" passed?

We have to answer this every single time...  :)  it makes the code more 
readable, and this is common practice all over the place.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html