netdev - Re: [Bugme-new] [Bug 9128] New: PF_KEY SADB_GET messages return SADB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071005103755.a1c86e7d.akpm@linux-foundation.org>
Date:	Fri, 5 Oct 2007 10:37:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	netdev@...r.kernel.org, chardin@...re.com
Cc:	bugme-daemon@...zilla.kernel.org,
	Joy Latten <latten@...tin.ibm.com>,
	Eric Paris <eparis@...isplace.org>,
	James Morris <jmorris@...ei.org>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [Bugme-new] [Bug 9128] New: PF_KEY SADB_GET messages return
 SADB_DUMP from the kernel


(Please reply via emailed reply-to-all, not via the bugzilla web interface)

On Fri,  5 Oct 2007 09:01:50 -0700 (PDT)
bugme-daemon@...zilla.kernel.org wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=9128
> 
>            Summary: PF_KEY SADB_GET messages return SADB_DUMP from the
>                     kernel
>            Product: Networking
>            Version: 2.5
>      KernelVersion: 2.6.18
>           Platform: All
>         OS/Version: Linux
>               Tree: Mainline
>             Status: NEW
>           Severity: normal
>           Priority: P1
>          Component: Other
>         AssignedTo: acme@...stprotocols.net
>         ReportedBy: chardin@...re.com
> 
> 
> Most recent kernel where this bug did not occur:
> Distribution: Centos 5
> Hardware Environment: Dell 490
> Software Environment: Centos 5
> Problem Description:
> Sending an SADB_GET to the PF_KEY socket returns an SADB_DUMP in the out_hdr
> 
> Steps to reproduce:
> Send an SADB_GET to the PF_KEY socket and dump the returned packet
> 
> 
> This patch should fix the problem
> diff --git a/net/key/af_key.c b/net/key/af_key.c
> index 5502df1..7a5e993 100644
> --- a/net/key/af_key.c
> +++ b/net/key/af_key.c
> @@ -1546,7 +1546,7 @@ static int pfkey_get(struct sock *sk, struct sk_buff
> *skb,
> 
>         out_hdr = (struct sadb_msg *) out_skb->data;
>         out_hdr->sadb_msg_version = hdr->sadb_msg_version;
> -       out_hdr->sadb_msg_type = SADB_DUMP;
> +       out_hdr->sadb_msg_type = SADB_GET;
>         out_hdr->sadb_msg_satype = pfkey_proto2satype(proto);
>         out_hdr->sadb_msg_errno = 0;
>         out_hdr->sadb_msg_reserved = 0;
> 

Please submit kernel patches via email, as per
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt.  Net patches
should be sent to netdev@...r.kernel.org and perhaps
linux-kernel@...r.kernel.org.

But whatever - I can convert this patch into a suitable one and send it in
to David if people think it is good?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html