lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <47090F55.3020800@colorfullife.com> Date: Sun, 07 Oct 2007 18:54:45 +0200 From: Manfred Spraul <manfred@...orfullife.com> To: Jeff Garzik <jgarzik@...ox.com> CC: Yinghai Lu <yhlu.kernel@...il.com>, Ayaz Abdulla <aabdulla@...dia.com>, nedev <netdev@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, David Miller <davem@...emloft.net>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: MSI interrupts and disable_irq Jeff Garzik wrote: > > Interested parties should try the forcedeth patches I just posted :) > The patches look good, but I would still prefer to understand why the current implementation causes crashes before rewriting everything. I've just noticed that netpoll_send_skb() calls ->hard_start_xmit() and ->poll() within local_irq_save(). Thus it seems that spin_lock_irqsave() must be used in the poll() and hard_start_xmit() callbacks, at least in nics that support POLL_CONTROLLER :-( -- Manfred - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists