netdev - RE: [PATCH 2/3][NET_BATCH] net core use batching

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D5C1322C3E673F459512FB59E0DDC32903C0821A@orsmsx414.amr.corp.intel.com>
Date:	Tue, 9 Oct 2007 11:48:45 -0700
From:	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
To:	"Jeff Garzik" <jeff@...zik.org>,
	"David Miller" <davem@...emloft.net>
Cc:	<hadi@...erus.ca>, <krkumar2@...ibm.com>, <johnpol@....mipt.ru>,
	<herbert@...dor.apana.org.au>, <kaber@...sh.net>,
	<shemminger@...ux-foundation.org>, <jagana@...ibm.com>,
	<Robert.Olsson@...a.slu.se>, <rick.jones2@...com>,
	<xma@...ibm.com>, <gaagaan@...il.com>, <netdev@...r.kernel.org>,
	<rdreier@...co.com>, <mcarlson@...adcom.com>, <mchan@...adcom.com>,
	<general@...ts.openfabrics.org>, <tgraf@...g.ch>,
	<randy.dunlap@...cle.com>, <sri@...ibm.com>
Subject: RE: [PATCH 2/3][NET_BATCH] net core use batching

> IMO the net driver really should provide a hint as to what it wants.
> 
> 8139cp and tg3 would probably prefer multiple TX queue 
> behavior to match silicon behavior -- strict prio.

If I understand what you just said, I disagree.  If your hardware is
running strict prio, you don't want to enforce strict prio in the qdisc
layer; performing two layers of QoS is excessive, and may lead to
results you don't want.  The reason I added the DRR qdisc is for the Si
that has its own queueing strategy that is not RR.  For Si that
implements RR (like e1000), you can either use the DRR qdisc, or if you
want to prioritize your flows, use PRIO.

-PJ Waskiewicz
peter.p.waskiewicz.jr@...el.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html