lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Oct 2007 15:04:23 -0400 From: Jeff Garzik <jeff@...zik.org> To: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com> CC: David Miller <davem@...emloft.net>, hadi@...erus.ca, krkumar2@...ibm.com, johnpol@....mipt.ru, herbert@...dor.apana.org.au, kaber@...sh.net, shemminger@...ux-foundation.org, jagana@...ibm.com, Robert.Olsson@...a.slu.se, rick.jones2@...com, xma@...ibm.com, gaagaan@...il.com, netdev@...r.kernel.org, rdreier@...co.com, mcarlson@...adcom.com, mchan@...adcom.com, general@...ts.openfabrics.org, tgraf@...g.ch, randy.dunlap@...cle.com, sri@...ibm.com Subject: Re: [PATCH 2/3][NET_BATCH] net core use batching Waskiewicz Jr, Peter P wrote: >> IMO the net driver really should provide a hint as to what it wants. >> >> 8139cp and tg3 would probably prefer multiple TX queue >> behavior to match silicon behavior -- strict prio. > > If I understand what you just said, I disagree. If your hardware is > running strict prio, you don't want to enforce strict prio in the qdisc > layer; performing two layers of QoS is excessive, and may lead to > results you don't want. The reason I added the DRR qdisc is for the Si > that has its own queueing strategy that is not RR. For Si that > implements RR (like e1000), you can either use the DRR qdisc, or if you > want to prioritize your flows, use PRIO. A misunderstanding, I think. To my brain, DaveM's item #2 seemed to assume/require the NIC hardware to balance fairly across hw TX rings, which seemed to preclude the 8139cp/tg3 style of strict-prio hardware. That's what I was responding to. As long as there is some modular way to fit 8139cp/tg3 style multi-TX into our universe, I'm happy :) Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists