netdev - Re: e100 problems in .23rc8 ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071011232411.GA21071@gondor.apana.org.au>
Date:	Fri, 12 Oct 2007 07:24:11 +0800
From:	Herbert Xu <herbert.xu@...hat.com>
To:	"Kok, Auke" <auke-jan.h.kok@...el.com>
Cc:	Dave Jones <davej@...hat.com>, netdev@...r.kernel.org,
	esandeen@...hat.com, dmack@...iper.net
Subject: Re: e100 problems in .23rc8 ?

On Thu, Oct 11, 2007 at 09:10:34AM -0700, Kok, Auke wrote:
> >>
> >> commit 416b5d10afdc797c21c457ade3714e8f2f75edd9
> >> Author: Auke Kok <auke-jan.h.kok@...el.com>
> >> Date:   Fri Jun 1 10:22:39 2007 -0700
> >>
> >>     e1000: disable polling before registering netdevice
> 
> this patch actually called napi_disable() in the probe routine which was wrong,
> but e100 does not do that. Nonetheless e100 doesn't call netif_carrier_off() and
> netif_stop_queue(), so to make e100 the same as e1000 we should probably do this,
> see below.

Back then we didn't have napi_disable at all.  That patch calls
netif_poll_disable which has different semantics.

> Dave, can you see if this resolves the issue for you? If so then we might want to
> push this to -stable.

The problem is with netif_poll so this patch probably won't help.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html