netdev - Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <470E1C42.1050901@hitachi.com>
Date:	Thu, 11 Oct 2007 21:51:14 +0900
From:	Satoshi OSHIMA <satoshi.oshima.fk@...achi.com>
To:	Stephen Hemminger <shemminger@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev <netdev@...r.kernel.org>, ?? ?? <yoshfuji@...ux-ipv6.org>,
	Yumiko SUGITA <yumiko.sugita.yf@...achi.com>,
	"??@...Hat" <haoki@...hat.com>
Subject: Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory
 limitation

Hi Stephen,

Thank you for your comment.

>>  	{
>> +		.ctl_name	= NET_UDP_MEM,
>> +		.procname	= "udp_mem",
>> +		.data		= &sysctl_udp_mem,
>> +		.maxlen		= sizeof(sysctl_udp_mem),
>> +		.mode		= 0644,
>> +		.proc_handler	= &proc_dointvec
>> +	},
>> +	{
>>  		.ctl_name	= NET_TCP_APP_WIN,
>>  		.procname	= "tcp_app_win",
>>  		.data		= &sysctl_tcp_app_win,
> 
> if you use &proc_dointvec_minmax, then you could inforce min/max
> values for udp_mem for the sysctl

udp_mem has two meanings:
* turn off this limitation function (currently udp_mem<=4096)
* limit udp memory (currently udp_mem>4096)

To realize this,  udp_mem is evaluated whether udp_mem equals
4096 or smaller in UDP and IP layers.

If udp_mem has proc_dointvec_minmax or dedicated proc handler,
turn off check must be done in UDP and IP layers. This means
there is no reduction of the check in UDP and IP layers.


If you pointed out that minus value of udp_mem is strange,
I agree. I'll fix it.

How about this?
min=4096     (and turn off limitation)
udp_mem>4096 (and turn on limitation)


Satoshi Oshima

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html