netdev - Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory limitation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071011124656.01dd575b@freepuppy.rosehill>
Date:	Thu, 11 Oct 2007 12:46:56 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Satoshi OSHIMA <satoshi.oshima.fk@...achi.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	David Miller <davem@...emloft.net>,
	Evgeniy Polyakov <johnpol@....mipt.ru>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	netdev <netdev@...r.kernel.org>, ?? ?? <yoshfuji@...ux-ipv6.org>,
	Yumiko SUGITA <yumiko.sugita.yf@...achi.com>,
	"??@...Hat" <haoki@...hat.com>
Subject: Re: [RFC/PATCH 4/4] UDP memory usage accounting (take 4): memory
 limitation

On Thu, 11 Oct 2007 21:51:14 +0900
Satoshi OSHIMA <satoshi.oshima.fk@...achi.com> wrote:

> Hi Stephen,
> 
> Thank you for your comment.
> 
> >>  	{
> >> +		.ctl_name	= NET_UDP_MEM,
> >> +		.procname	= "udp_mem",
> >> +		.data		= &sysctl_udp_mem,
> >> +		.maxlen		= sizeof(sysctl_udp_mem),
> >> +		.mode		= 0644,
> >> +		.proc_handler	= &proc_dointvec
> >> +	},
> >> +	{
> >>  		.ctl_name	= NET_TCP_APP_WIN,
> >>  		.procname	= "tcp_app_win",
> >>  		.data		= &sysctl_tcp_app_win,
> > 
> > if you use &proc_dointvec_minmax, then you could inforce min/max
> > values for udp_mem for the sysctl

One other comment. Sysctl value indexes are deprecated at this point
so all new values should use CTL_UNNUMBERED.  Therefore unless NET_UDP_MEM
already exists, please don't add it.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html