netdev - Re: [IPv6] Update setsockopt(IPV6_MULTICAST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OFF4E419EA.816C7D2D-ON88257371.0061B23A-88257371.0061CC92@us.ibm.com>
Date:	Thu, 11 Oct 2007 10:49:14 -0700
From:	David Stevens <dlstevens@...ibm.com>
To:	Brian Haley <brian.haley@...com>
Cc:	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	netdev-owner@...r.kernel.org,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [IPv6] Update setsockopt(IPV6_MULTICAST_IF) to support RFC 3493, try2

Acked-by: David L Stevens <dlstevens@...ibm.com>

> 
> Signed-off-by: Brian Haley <brian.haley@...com>
> diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c
> index 532425d..1334fc1 100644
> --- a/net/ipv6/ipv6_sockglue.c
> +++ b/net/ipv6/ipv6_sockglue.c
> @@ -539,12 +539,15 @@ done:
>     case IPV6_MULTICAST_IF:
>        if (sk->sk_type == SOCK_STREAM)
>           goto e_inval;
> -      if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != val)
> -         goto e_inval;
> 
> -      if (__dev_get_by_index(&init_net, val) == NULL) {
> -         retv = -ENODEV;
> -         break;
> +      if (val) {
> +         if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != val)
> +            goto e_inval;
> +
> +         if (__dev_get_by_index(&init_net, val) == NULL) {
> +            retv = -ENODEV;
> +            break;
> +         }
>        }
>        np->mcast_oif = val;
>        retv = 0;

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html