netdev - Re: [PATCH][BNX2X] round three

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1192125219.29746.143.camel@eliezer>
Date:	Thu, 11 Oct 2007 19:53:39 +0200
From:	"Eliezer Tamir" <eliezert@...adcom.com>
To:	"David Miller" <davem@...emloft.net>
cc:	netdev@...r.kernel.org, jeff@...zik.org, mchan@...adcom.com
Subject: Re: [PATCH][BNX2X] round three

On Wed, 2007-10-10 at 17:59 -0700, David Miller wrote:

...

> I was going to add this to the tree for 2.6.24 but there is simply
> too much super-ugly stuff in this driver for me to do so.

We will rewrite bnx2x_hsi.h bnx2x_init.h and bnx2x_init_vlaues.h.

Does bnx2x_asm.h look OK?


> Look, there is zero way I'm adding a driver that's written like this
> to the tree.
> 
...

> This huge header file full of register programming magic goes way
> beyond the limits of "reasonable" and has to go.

Will it be OK if we replace it with 4-5 headers so we can maintain them
better manually. (I'm asking what is the upper bound to the number of
header files you would consider reasonable for this driver.)

Thanks
Eliezer


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html