netdev - Re: net-2.6.24 breaks powerpc mysteriously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18190.61294.191189.193153@cargo.ozlabs.ibm.com>
Date:	Fri, 12 Oct 2007 13:52:14 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	netdev@...r.kernel.org, Sam Ravnborg <sam@...nborg.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: net-2.6.24 breaks powerpc mysteriously

Andrew Morton writes:

> arch/powerpc/boot/inflate.c:920:19: errno.h: No such file or directory
> arch/powerpc/boot/inflate.c:921:18: slab.h: No such file or directory
> arch/powerpc/boot/inflate.c:922:21: vmalloc.h: No such file or directory

We used to have our own copies of inflate.c etc. for the zImage
wrapper code to use under arch/powerpc/boot.  Then someone said "why
do we have two copies of these files?" and did a patch to make the
build process copy the files from lib/zlib_inflate over and compile
them.  (We can't just use the compiled .o files from lib/zlib_inflate
because the wrapper is 32-bit whereas the kernel is often 64-bit.)

Now it seems someone has made changes to the lib/zlib_inflate versions
that are OK in the context of the kernel but not in the zImage (which
is a separate program).  Avoiding this kind of breakage was the reason
why I made arch/powerpc/boot have its own copies originally.

So Andrew, what do you think is better - arch/powerpc/boot having its
own copies of the zlib_inflate stuff, or #ifdefs of some kind in
lib/zlib_inflate/*.c?

Paul.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html