netdev - Re: net-2.6.24 breaks powerpc mysteriously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 12 Oct 2007 14:09:51 +1000
From:	Paul Mackerras <paulus@...ba.org>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org,
	sam@...nborg.org, benh@...nel.crashing.org,
	vda.linux@...glemail.com
Subject: Re: net-2.6.24 breaks powerpc mysteriously

David Miller writes:

> The only thing we touched in zlib is in the patch below.
> 
> I suspect the lib/zlib_inflate/inflate.c changes, I had no idea that
> some pieces of code try to use this into userspace.

Not userspace; the zImage wrapper uses inflate.c to gunzip the
compressed kernel image.  It is a separate program to the kernel,
however, and is compiled in an environment where the headers it uses
are not the kernel headers.

> I supposed a hacky fix is to add __KERNEL__ ifdef protection around
> zlib_inflate_blob() and those troublesome includes.  A nicer fix is

That would do, but I don't see why zlib_inflate_blob had to be added
to inflate.c rather than being in a new file under lib/zlib_inflate.
If nothing else, that bloats configs that currently use inflate.c (in
the kernel) but don't need zlib_inflate_blob() - which would be all
the existing uses. :)

Paul.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html