lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 14 Oct 2007 16:30:06 -0600 From: ebiederm@...ssion.com (Eric W. Biederman) To: Jesper Juhl <jesper.juhl@...il.com> Cc: netdev@...r.kernel.org, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Alan Cox <alan@...hat.com>, Alexey Kuznetsov <kuznet@....inr.ac.ru>, David Miller <davem@...emloft.net> Subject: Re: Don't leak 'listeners' in netlink_kernel_create() Jesper Juhl <jesper.juhl@...il.com> writes: > From: Jesper Juhl <jesper.juhl@...il.com> > Subject: Don't leak 'listeners' in netlink_kernel_create() > > The Coverity checker spotted that we'll leak the storage allocated > to 'listeners' in netlink_kernel_create() when the > if (!nl_table[unit].registered) > check is false. > > This patch avoids the leak. > > > Signed-off-by: Jesper Juhl <jesper.juhl@...il.com> This patch appears trivially correct to me. Acked-by: "Eric W. Biederman" <ebiederm@...ssion.com> > --- > > af_netlink.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- linux-2.6/net/netlink/af_netlink.c~ 2007-10-14 23:29:50.000000000 +0200 > +++ linux-2.6/net/netlink/af_netlink.c 2007-10-14 23:29:50.000000000 +0200 > @@ -1378,6 +1378,8 @@ netlink_kernel_create(struct net *net, i > nl_table[unit].cb_mutex = cb_mutex; > nl_table[unit].module = module; > nl_table[unit].registered = 1; > + } else { > + kfree(listeners); > } > netlink_table_ungrab(); > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists