netdev - Re: netif_napi_add vs. multiple netdev's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071016091035.5fcd6d2e@freepuppy.rosehill>
Date:	Tue, 16 Oct 2007 09:10:35 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	benh@...nel.crashing.org
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: netif_napi_add vs. multiple netdev's

On Tue, 16 Oct 2007 15:47:13 +1000
Benjamin Herrenschmidt <benh@...nel.crashing.org> wrote:

> Hi Stehphen !
> 
> The new netif_napi_add() function takes a netdev argument. In the EMAC
> case, there is one NAPI instance working on behalf of multiple netdev's,
> so that isn't very useful. For my EMAC patch (just posted to you & the
> list), I'm not passing NULL, but I'm wondering what would be a good way
> to handle netpoll here...

The problem is that netpoll only has a handle to the device being used
as a netconsole, but may need to activate the NAPI poll routine to
cleanup state. Perhaps teaching netpoll about N to 1 mappings would
be better.

> 
> The way it's currently implemented, there's a list of NAPI's attached to
> the netdev, so obviously, that won't work for my usage scenario.

sky2 driver has potentially 2 ports for 1 NAPI instance.

> I'm not sure what's the best data structure that would be suitable for
> both N ndev's for 1 NAPI and 1 ndev for N NAPI's though... I could
> allocate "stub" list heads and queue those up, but that's a bit gross...

The new interface doesn't change anything. The old code had the
same problem vis-a-vis netpoll.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html