lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Oct 2007 17:30:32 -0700 (PDT) From: David Miller <davem@...emloft.net> To: Emilian.Medve@...escale.com Cc: jgarzik@...ox.com, leoli@...escale.com, netdev@...r.kernel.org, linuxppc-dev@...abs.org Subject: Re: [PATCH] [POWERPC] ucc_geth: Eliminate compile warnings From: Emil Medve <Emilian.Medve@...escale.com> Date: Thu, 18 Oct 2007 17:15:13 -0500 > drivers/net/ucc_geth.c: In function 'ucc_geth_startup': > drivers/net/ucc_geth.c:2614: warning: assignment makes integer from pointer without a cast > drivers/net/ucc_geth.c:2651: warning: assignment makes integer from pointer without a cast > > Signed-off-by: Emil Medve <Emilian.Medve@...escale.com> It only kills the warning on 32-bit systems, the cast is wrong either way. > ugeth->tx_bd_ring_offset[j] = > - kmalloc((u32) (length + align), GFP_KERNEL); > + (u32)kmalloc(length + align, GFP_KERNEL); > > if (ugeth->tx_bd_ring_offset[j] != 0) > ugeth->p_tx_bd_ring[j] = Pointers can be up to "unsigned long" in size, therefore that is the minimal amount of storage you need to store them into if they are needed in integer form for some reason. Any cast from pointer to integer like this is a huge red flag. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists