netdev - Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200710221929.04035.oliver@neukum.org>
Date:	Mon, 22 Oct 2007 19:29:03 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	linux-usb-devel@...ts.sourceforge.net
Cc:	Valentine Barshak <vbarshak@...mvista.com>, netdev@...r.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer allocations.

Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
>  static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
>  {
>         struct usbnet *dev = netdev_priv(netdev);
> +       void *buf;
>         u16 res;
>  
>         mutex_lock(&dev->phy_mutex);
>         asix_set_sw_mii(dev);
> +
> +       buf = kmalloc(2, GFP_KERNEL);

This is done under lock. Can you allocate the buffer once and reuse it?

	Regards
		Oliver

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html