lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 22 Oct 2007 23:22:59 +0400
From:	Valentine Barshak <>
To:	Oliver Neukum <>
Subject: Re: [linux-usb-devel] [PATCH] USB: net: Fix asix read transfer buffer

Oliver Neukum wrote:
> Am Montag 22 Oktober 2007 schrieb Valentine Barshak:
>>  static int asix_mdio_read(struct net_device *netdev, int phy_id, int loc)
>>  {
>>         struct usbnet *dev = netdev_priv(netdev);
>> +       void *buf;
>>         u16 res;
>>         mutex_lock(&dev->phy_mutex);
>>         asix_set_sw_mii(dev);
>> +
>> +       buf = kmalloc(2, GFP_KERNEL);
> This is done under lock. Can you allocate the buffer once and reuse it?
> 	Regards
> 		Oliver
I think we can use 2 bytes of the usbnet data buffer for this.
I'll submit a new patch soon.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists