netdev - [RFC][BNX2X] .h files rewrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 28 Oct 2007 22:17:50 +0200
From:	"Eliezer Tamir" <eliezert@...adcom.com>
To:	"davem@...emloft.net" <davem@...emloft.net>,
	"Michael Chan" <mchan@...adcom.com>,
	"jeff@...zik.org" <jeff@...zik.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
cc:	"Max Asbock" <masbock@...ibm.com>
Subject: [RFC][BNX2X] .h files rewrite

Dave,

Please take a look and tell me if this is better than the last attempt.

Main changes:

* Rewrite of the init code: 
	1. Full rewrite of the generated code into something easier to read.
	2. Removed zeroes by adding a zero command.
	3. Big chucks of data are read by the chip using the DMA engine (instead of being written by the driver).
	4. Gzipped more of the data.

* Removed BE microcode, the swapping is done in the driver instead.

* Rewrite of the HSI - broke it into three files bnx2x_hsi.h bnx2x_reg.h and bnx2x_fw_defs.h

* Fixed SPARSE warnings.

* Fixed all but three checkpatch.pl warnings. (IMHO they are false positives)

The diff is against latest net-2.6.

ftp link:
ftp://Net_sys_anon@...1.broadcom.com/0001-bnx2x-h-file-rewrite.txt

gzipped:
ftp://Net_sys_anon@...1.broadcom.com/0001-bnx2x-h-file-rewrite.txt.gz

(will also attache patch inline as reply to this email for review)

Thanks
Eliezer


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html