netdev - Re: [PATCH] NET: Add the helper kernel_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Nov 2007 10:03:41 -0800
From:	Mark Fasheh <mark.fasheh@...cle.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
Cc:	netdev@...r.kernel.org, Paul Clements <Paul.Clements@...eleye.com>,
	Steve French <sfrench@...ba.org>,
	David Howells <dhowells@...hat.com>,
	David S Miller <davem@...emloft.net>
Subject: Re: [PATCH] NET: Add the helper kernel_sock_shutdown()

On Thu, Nov 08, 2007 at 07:01:36PM -0500, Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@...app.com>
> 
> ...and fix a couple of bugs in the NBD, CIFS and OCFS2 socket handlers.
> 
> Looking at the sock->op->shutdown() handlers, it looks as if all of them
> take a SHUT_RD/SHUT_WR/SHUT_RDWR argument instead of the
> RCV_SHUTDOWN/SEND_SHUTDOWN arguments.
> Add a helper, and then define the SHUT_* enum to ensure that kernel users
> of shutdown() don't get confused.

That looks pretty good - any objection to naming the enum and using that
name in the prototype for kernel_sock_shutdown() so it's even more obvious
what type of shutdown argument this expects?
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@...cle.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html