netdev - RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39C363776A4E8C4A94691D2BD9D1C9A1029EDC23@XCH-NW-7V2.nw.nos.boeing.com>
Date:	Mon, 12 Nov 2007 14:26:12 -0800
From:	"Templin, Fred L" <Fred.L.Templin@...ing.com>
To:	"Vlad Yasevich" <vladislav.yasevich@...com>
Cc:	<netdev@...r.kernel.org>, <yoshfuji@...ux-ipv6.org>
Subject: RE: [Resend][PATCH 01/05] ipv6: RFC4214 Support (4)

> Ok, thanks for the explanation.  One questions is though why
> do we need all the #if defines() throughout the file?

Was just trying to follow what I thought was
convention, but I'm willing to be educated...

> Most distros end up enabled almost everything anyway.  Looking
> at the code, there is really nothing that needs a conditional.
> Removing the conditionals would make things cleaner.

Works for me unless there are any objections. Anyone?

Fred
fred.l.templin@...ing.com
 
> Just some of my thoughts.
> 
> Thanks
> -vlad
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html