lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 13 Nov 2007 20:16:47 +0800 From: Herbert Xu <herbert@...dor.apana.org.au> To: David Miller <davem@...emloft.net> Cc: kaber@...sh.net, joonwpark81@...il.com, w@....eu, cfriesen@...tel.com, auke-jan.h.kok@...el.com, netdev@...r.kernel.org, djohnson+linux-kernel@...starentnetworks.com, linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when promiscuous mode On Tue, Nov 13, 2007 at 04:06:24AM -0800, David Miller wrote: > > > In other words we can make it so that nobody is in promiscuous > > mode and therefore have to disable VLAN acceleration *unless* > > they really want to be in that state. In which case it would > > imply that they wish to see everything and therefore we should > > disable VLAN acceleration. > > This is too complicated, we have multiple unicast MAC support > in the driver API already, let's simply use it. Yes I agree. People not using Patrick's new API deserves to get poor performance so they can switch over sooner :) What I was trying to say above is that e1000 currently uses the old set_multicast_list interface (rather than dev_set_rx_mode) so it's not immediately obvious why we're in promiscuous mode. We could look at dev->promiscuity - !!uc_count but that feels a bit fragile. Perhaps those who want to push this patch should be encouraged to convert e1000 to the new interface :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists