netdev - Re: [PATCH 2/7] CAN: Add PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 15 Nov 2007 04:05:30 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	urs.thuermann@....de
Cc:	joe@...ches.com, oliver@...tkopp.net,
	shemminger@...ux-foundation.org, netdev@...r.kernel.org,
	kaber@...sh.net, oliver.hartkopp@...kswagen.de
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module

From: Urs Thuermann <urs.thuermann@....de>
Date: 15 Nov 2007 12:51:34 +0100

> I prefer our code because it is shorter (fits into one line) and can
> be used anywhere where an expression is allowed compared to only where
> a statement is allowed.  Actually, I first had
> 
>         #define DBG( ... )   ((debug & 1) && printk( ... ))
> 
> and so on, but that didn't work with can_debug_{cframe,sbk} since they
> return void.
> 
> Admitted, the benefit of expr vs. statement is really negligible and
> since this issue has come up several times I will change these macros
> using do-while.

I really frown upon these local debugging macros people tend to want
to submit with their changes.

It really craps up the tree, even though it might be useful to you.

So please remove this stuff or replace the debugging statements
with some generic kernel debugging facility, there are several.

Thank you.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html