netdev - Re: [PATCH 2/7] CAN: Add PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071115150938.GA22825@uranus.ravnborg.org>
Date:	Thu, 15 Nov 2007 16:09:38 +0100
From:	Sam Ravnborg <sam@...nborg.org>
To:	Urs Thuermann <urs.thuermann@....de>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Oliver Hartkopp <oliver.hartkopp@...kswagen.de>
Subject: Re: [PATCH 2/7] CAN: Add PF_CAN core module

> > > +
> > > +struct timer_list stattimer; /* timer for statistics update */
> > > +struct s_stats  stats;       /* packet statistics */
> > > +struct s_pstats pstats;      /* receive list statistics */
> > 
> > More global variables without prefix.
> 
> These variables are not exported with EXPORT_SYMBOL, so there should
> be no name conflict.  They cannot be made static because they are used
> in af_can.c and proc.c.  Nevertheless we can prefix them with can_ if
> you still think it's necessary.

When this is build-in they will be in the global kernel namespace.
So please add can_ prefix.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html