netdev - Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071116.010548.94286711.davem@davemloft.net>
Date:	Fri, 16 Nov 2007 01:05:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	the.sator@...il.com
Cc:	kuznet@....inr.ac.ru, linux-kernel@...r.kernel.org,
	jmorris@...ei.org, netdev@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] net/ipv4/arp.c: Fix arp reply when sender ip 0

From: "Jonas Danielsson" <the.sator@...il.com>
Date: Fri, 16 Nov 2007 09:30:11 +0100

> 2007/11/16, David Miller <davem@...emloft.net>:
> > From: "Jonas Danielsson" <the.sator@...il.com>
> > Date: Thu, 15 Nov 2007 22:40:13 +0100
> >
> > > Is there a reason that the target hardware address isn't the target
> > > hardware address?
> >
> 
> 
> > Because of this, in cases where a choice can be made Linux will
> > advertise what is most likely to result in successful communication.
> >
> > This is likely why we are changing that target address to the one of
> > the interface actually sending back the reply rather than the zero
> > value you used.
> >
> > In fact I think this information can be useful to the sender of
> > the DAD request.
> >
> 
> There seem to be some confusion about what my patch really does. It
> does not set the hardware address to a zero value.

I knew you were talking about the IP address not the hardware
address.

> The reply from the Linux kernel in computer A, before the patch would look like:
> 
> Reply:
> Opcode: reply (0x0002)
> Sender HW: 00:AA.00:AA:00:AA
> Sender IP:   192.168.0.1
> Target HW:  00:AA:00:AA:00:AA
> Target IP:    192.168.0.1

And this is exactly a sensible response in my opinion.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html